-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Bouncer test for broker level screening #5377
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5377 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 495 495
Lines 86276 86345 +69
Branches 86276 86345 +69
======================================
- Hits 61717 61650 -67
- Misses 21783 21893 +110
- Partials 2776 2802 +26 ☔ View full report in Codecov by Sentry. |
true, | ||
btcRefundAddress, | ||
0, | ||
MILLI_SECS_PER_BLOCK * 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
MILLI_SECS_PER_BLOCK * 2, | |
MILLI_SECS_PER_BLOCK * BLOCKS_TO_WAIT, |
also these are all the same. if we need to wait the same duration, then would just factor that out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now. But maybe not forever. It's likely to change if we maybe want to extend the test suite, modify it or play with different values to see what the results are. We usually define this kind of constants in test suites. Don't see why it should be bad...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just unnecessary complexity atm, we can add the parameterisation when we need it (which might be never) - i won't block the the PR because of it, but yeah, is unnecessary
* tests: Added first draft of bouncer test * chore: added current work in progress * chore: added current status * chore: restored * chore: added current status * chore: added current state * tests: integrated broker level screening test * chore: Tidy up * chore: eslint / prettier * chore: added some comments + smallish refactors * chore: parse unknown to string type * chore: Make test verification more explicit * chore: addressed comments * chore: removed from runAllConcurrentTests * feature: added mode to run some tests concurrent in localnet * chore: Fixed var name
* origin/main: feat: add version and affiliates to UTXO encoding (#5385) chore: bump all versions to 1.8.0 and remove old migrations. (#5327) feat: update custom_rpc, runtime_api and broker api for broker level screening (#5341) tests: Bouncer test for broker level screening (#5377) Feat: Private Broker Channel Witnessing (#5383) # Conflicts: # state-chain/runtime/src/lib.rs
Pull Request
Closes: PRO-1746
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Adds a bouncer tests for testing broker level screening on-chain functionality. We are covering the follwing scenarios in this test:
Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breaking
label. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.