Add bouncer tests involving the full deposit monitor pipeline. #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MxmUrw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
======================================
Coverage 71% 72%
======================================
Files 489 490 +1
Lines 86667 86768 +101
Branches 86667 86768 +101
======================================
+ Hits 61958 62214 +256
+ Misses 21798 21617 -181
- Partials 2911 2937 +26 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
MxmUrw
force-pushed
the
tests/pro-1773/add-bouncer-tests-for-deposit-monitor
branch
8 times, most recently
from
6858c9a to
3580cc3
Compare
MxmUrw
force-pushed
the
tests/pro-1773/add-bouncer-tests-for-deposit-monitor
branch
5 times, most recently
from
9f47df9 to
8ac6fe4
Compare
kylezs
reviewed
Nov 12, 2024
ahasna
reviewed
Nov 12, 2024
since we don't need to stop the bitcoin node anymore.
- Use axios for sending requests. - Use a simpler health check. - Smaller fixes. Additional changes: - Integrate new "/mockmode" feature of deposit monitor which controls the behaviour of the mock analysis provider.
MxmUrw
force-pushed
the
tests/pro-1773/add-bouncer-tests-for-deposit-monitor
branch
from
de38342 to
3fc522f
Compare
kylezs
approved these changes
Nov 13, 2024
We don't want to break the bouncer tests if we change the deposit-monitor configuration for example.
kylezs
approved these changes
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This change is supported by moving the start code for the deposit-monitor to its own file.
MxmUrw
force-pushed
the
tests/pro-1773/add-bouncer-tests-for-deposit-monitor
branch
from
4595cbd to
e59d9d1
Compare
MxmUrw
force-pushed
the
tests/pro-1773/add-bouncer-tests-for-deposit-monitor
branch
from
e59d9d1 to
fcc5e8c
Compare
kylezs
approved these changes
Nov 18, 2024
MxmUrw
deleted the
tests/pro-1773/add-bouncer-tests-for-deposit-monitor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1773
Closes: PRO-1774
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
This PR integrates the deposit-monitor (https://github.com/chainflip-io/chainflip-deposit-monitor) into the localnet configuration. The
broker_level_screeningtest now uses the monitor to mark transactions as tainted.