Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable idempotency checks on try-runtime for upgrade-test #5391

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Nov 7, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

We should check for idempotency to be safe against accidentally leaving migrations in, which could result in a migration being run twice, which could corrupt state.

@kylezs kylezs requested a review from dandanlen November 7, 2024 10:12
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72%. Comparing base (9842dea) to head (7d067fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5391    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        486     486            
  Lines      85863   85727   -136     
  Branches   85863   85727   -136     
======================================
- Hits       61515   61316   -199     
- Misses     21533   21586    +53     
- Partials    2815    2825    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 6840f63 Nov 7, 2024
49 checks passed
@dandanlen dandanlen deleted the chore/enable-idempotency-checks branch November 7, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants