Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runtime API versioning for monitoring API #5393

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

marcellorigotti
Copy link
Contributor

@marcellorigotti marcellorigotti commented Nov 7, 2024

Pull Request

Closes: PRO-1611

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (9842dea) to head (dd180b7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/runtime/src/monitoring_apis.rs 11% 23 Missing and 2 partials ⚠️
state-chain/custom-rpc/src/monitoring.rs 0% 7 Missing ⚠️
state-chain/runtime/src/lib.rs 0% 0 Missing and 2 partials ⚠️
state-chain/custom-rpc/src/lib.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5393    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        486     486            
  Lines      85863   85758   -105     
  Branches   85863   85758   -105     
======================================
- Hits       61515   61325   -190     
- Misses     21533   21612    +79     
- Partials    2815    2821     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen changed the title feat: set a precedent for runtime API versioning feat: runtime API versioning for monitoring API Nov 7, 2024
@dandanlen dandanlen enabled auto-merge November 7, 2024 12:50
@dandanlen dandanlen added this pull request to the merge queue Nov 7, 2024
kylezs pushed a commit that referenced this pull request Nov 7, 2024
* first implementation of runtime versioning

* use api_version()

* chore: fmt

---------

Co-authored-by: Daniel <daniel@chainflip.io>
Merged via the queue into main with commit b26821b Nov 7, 2024
49 checks passed
@dandanlen dandanlen deleted the feature/pro-1611 branch November 7, 2024 14:18
dandanlen added a commit that referenced this pull request Nov 7, 2024
* first implementation of runtime versioning

* use api_version()

* chore: fmt

---------

Co-authored-by: Daniel <daniel@chainflip.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants