Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deduplicate event finding logic #5412

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Nov 13, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Creating the util to reduce the extra duplication that was introduced in #5410

@kylezs kylezs marked this pull request as draft November 13, 2024 09:26
@kylezs kylezs force-pushed the refactor/deduplicate-event-finding-logic branch 2 times, most recently from dca5255 to 09b6054 Compare November 13, 2024 09:30
@kylezs kylezs marked this pull request as ready for review November 13, 2024 09:30
@kylezs kylezs force-pushed the refactor/deduplicate-event-finding-logic branch from 09b6054 to 2c4de10 Compare November 13, 2024 09:34
api/lib/src/lib.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (c22b70a) to head (2385040).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/lib/src/lib.rs 0% 19 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5412    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        489     489            
  Lines      86667   86526   -141     
  Branches   86667   86526   -141     
======================================
- Hits       61958   61764   -194     
- Misses     21798   21846    +48     
- Partials    2911    2916     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/lib/src/lib.rs Outdated Show resolved Hide resolved
@kylezs kylezs enabled auto-merge November 13, 2024 10:38
@kylezs kylezs added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 972b9b2 Nov 13, 2024
49 checks passed
@kylezs kylezs deleted the refactor/deduplicate-event-finding-logic branch November 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants