feat: Custom runtime api versioning + struct versioning #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5415 +/- ##
======================================
Coverage 71% 72%
======================================
Files 488 490 +2
Lines 86360 86792 +432
Branches 86360 86792 +432
======================================
+ Hits 61718 62217 +499
+ Misses 21731 21640 -91
- Partials 2911 2935 +24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dandanlen
approved these changes
Nov 18, 2024
Comment on lines
167
to
168
| #[obake(version("0.1.0"))] | ||
| #[obake(version("0.2.0"))] |
There was a problem hiding this comment.
We could align these versions with our own release versions? WDYT?
Otherwise we could use 1.0.0/2.0.0 etc. "0.1.0" seems a bit strange - like it's not 'complete'.
tbh. i'm not sure why it require a full semver-compatible version specifier. If it's not a breaking change (ie. patch version) then we wouldn't need a versioned struct?
dandanlen
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1793
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Replica of #5406 which was merged in 1.7, with the addition of using obake to create struct versioning.
This PR is here just to have an example in the codebase as a reference implementation.