Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move amm math into its own crate #5418

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

dandanlen
Copy link
Collaborator

Moves the amm math primitives into their own crate.

This allows sharing them more easily without depending on the amm (For example, this is why Price was added to cf-primitives: I moved it back.).

I also refactored some little things I noticed while making these changes (see the second two commits).

@dandanlen dandanlen requested a review from kylezs as a code owner November 15, 2024 11:04
@dandanlen dandanlen force-pushed the refactor/move-amm-math-into-own-crate branch from 2030c60 to 9a3591f Compare November 15, 2024 11:08
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 88.15490% with 52 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (755c6eb) to head (340157e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-pools/src/lib.rs 28% 22 Missing and 1 partial ⚠️
state-chain/runtime/src/lib.rs 0% 0 Missing and 19 partials ⚠️
state-chain/amm-math/src/lib.rs 97% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5418    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        489     490     +1     
  Lines      86863   86759   -104     
  Branches   86863   86759   -104     
======================================
- Hits       62401   62211   -190     
- Misses     21542   21608    +66     
- Partials    2920    2940    +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen force-pushed the refactor/move-amm-math-into-own-crate branch from 9a3591f to 47c4da8 Compare November 15, 2024 13:26
@dandanlen dandanlen force-pushed the refactor/move-amm-math-into-own-crate branch from 47c4da8 to 340157e Compare November 18, 2024 08:48
@dandanlen dandanlen enabled auto-merge November 18, 2024 08:49
@dandanlen dandanlen added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 238c90b Nov 18, 2024
49 checks passed
@dandanlen dandanlen deleted the refactor/move-amm-math-into-own-crate branch November 18, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants