Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce data needed for sol get block #5428

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

albert-llimos
Copy link
Contributor

@albert-llimos albert-llimos commented Nov 19, 2024

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

According to the docs when not passing those parameters (Rust's None) it doesn't default to those. Setting them prevents the call to get the rewards and more importantly the transaction data which we don't need.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (8e1619a) to head (e5ab94e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/witness/sol.rs 0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5428    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        490     490            
  Lines      86892   86770   -122     
  Branches   86892   86770   -122     
======================================
- Hits       62395   62211   -184     
- Misses     21563   21618    +55     
- Partials    2934    2941     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kylezs kylezs enabled auto-merge November 19, 2024 07:26
@kylezs kylezs added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit b8c1825 Nov 19, 2024
49 checks passed
@kylezs kylezs deleted the chore/improve-sol-get-block branch November 19, 2024 08:26
albert-llimos added a commit that referenced this pull request Nov 19, 2024
kylezs pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants