Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no intermediary swap amount for single-legs #5438

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Nov 21, 2024

Pull Request

Closes: PRO-1850

Cherry-picked from release/1.7

@dandanlen dandanlen requested review from kylezs and zoheb391 November 21, 2024 09:50
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (f35c07f) to head (e014543).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/runtime/src/lib.rs 0% 0 Missing and 9 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5438    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        490     490            
  Lines      86916   86793   -123     
  Branches   86916   86793   -123     
======================================
- Hits       62395   62216   -179     
- Misses     21587   21641    +54     
- Partials    2934    2936     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@kylezs
Copy link
Contributor

kylezs commented Nov 21, 2024

Think the error is related to the fix that will come here: #5436

@kylezs kylezs added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@kylezs kylezs added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit f007d1c Nov 27, 2024
49 checks passed
@kylezs kylezs deleted the fix/no-intermediary-asset-for-stable-swaps branch November 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants