Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check all restricted balances are above minimum when redeeming #5444

Merged

Conversation

nmammeri
Copy link
Contributor

@nmammeri nmammeri commented Nov 22, 2024

Pull Request

Closes: PRO-1821

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Added a check that makes sure we are not left with the situation where a restricted address is below MINIMUM_FUNDING.
  • This broke some other tests which were updated to take the new checks into consideration

@nmammeri nmammeri requested a review from dandanlen as a code owner November 22, 2024 14:06
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (c5f26eb) to head (3463b28).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-funding/src/lib.rs 71% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5444    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        491     491            
  Lines      86776   86659   -117     
  Branches   86776   86659   -117     
======================================
- Hits       62477   62307   -170     
- Misses     21699   21753    +54     
+ Partials    2600    2599     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks.

@nmammeri nmammeri force-pushed the feature/pro-1821/check-restricted-balances-above-minimum branch from 7cdf319 to 3463b28 Compare November 27, 2024 12:09
@dandanlen dandanlen added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@dandanlen dandanlen added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit c29edc1 Nov 27, 2024
49 checks passed
@dandanlen dandanlen deleted the feature/pro-1821/check-restricted-balances-above-minimum branch November 27, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants