Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps and remove stale audit exceptions #5446

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

dandanlen
Copy link
Collaborator

Make Audit Great Again

@dandanlen dandanlen requested a review from kylezs November 25, 2024 12:53
@dandanlen dandanlen requested a review from msgmaxim as a code owner November 25, 2024 15:22
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (277b152) to head (c41db5b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/state_chain_observer/client.rs 0% 9 Missing ⚠️
api/lib/src/lib.rs 0% 2 Missing ⚠️
api/lib/src/queries.rs 0% 2 Missing ⚠️
utilities/src/with_std/health.rs 0% 2 Missing ⚠️
...tate_chain_observer/client/extrinsic_api/signed.rs 0% 1 Missing ⚠️
...d_chain_source/chunked_by_vault/monitored_items.rs 0% 1 Missing ⚠️
engine/src/witness/evm/source.rs 0% 1 Missing ⚠️
state-chain/chains/src/btc.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5446    +/-   ##
======================================
  Coverage     72%     72%            
======================================
  Files        490     490            
  Lines      87053   86621   -432     
  Branches   87053   86621   -432     
======================================
- Hits       62423   62279   -144     
- Misses     21675   21741    +66     
+ Partials    2955    2601   -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust compiler got a bit better at lifetime inference it seems 🚀

@kylezs kylezs enabled auto-merge November 25, 2024 16:46
@dandanlen dandanlen force-pushed the fix/cargo-audit-251124 branch from b953649 to e7db834 Compare November 26, 2024 13:43
@dandanlen dandanlen force-pushed the fix/cargo-audit-251124 branch from ab6a615 to d17e3a2 Compare November 26, 2024 13:46
@kylezs kylezs added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@kylezs kylezs force-pushed the fix/cargo-audit-251124 branch from 9654e30 to c41db5b Compare November 27, 2024 08:17
@kylezs kylezs added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit f29b9b9 Nov 27, 2024
49 checks passed
@kylezs kylezs deleted the fix/cargo-audit-251124 branch November 27, 2024 09:50
nmammeri pushed a commit that referenced this pull request Nov 27, 2024
* fix: update deps and remove stale audit exceptions

* fix: update toolchain to support new dependencies + fix new clippy lints

* chore: fmt

* fix: update dylib build/download paths

* fix: imports

* fix: update debian settings

* chore: bump old engine version to 1_7_2

* chore: bump old version 1.7.1 -> 1.7.2

* fix: upload dylibs from /deps folder

* fix: add more /deps folders in CI jobs

* fix: flatten upload structure

---------

Co-authored-by: kylezs <zsembery.kyle@gmail.com>
nmammeri pushed a commit that referenced this pull request Nov 27, 2024
* fix: update deps and remove stale audit exceptions

* fix: update toolchain to support new dependencies + fix new clippy lints

* chore: fmt

* fix: update dylib build/download paths

* fix: imports

* fix: update debian settings

* chore: bump old engine version to 1_7_2

* chore: bump old version 1.7.1 -> 1.7.2

* fix: upload dylibs from /deps folder

* fix: add more /deps folders in CI jobs

* fix: flatten upload structure

---------

Co-authored-by: kylezs <zsembery.kyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants