Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy solana vault swap test hooks #5452

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Nov 27, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Uses new ability introduced in #5441 for the solana vault swap elections tests.

@kylezs kylezs requested a review from albert-llimos November 27, 2024 13:41
@kylezs kylezs requested a review from dandanlen as a code owner November 27, 2024 13:41
@kylezs kylezs changed the title chore: tidy vault swap test hooks chore: tidy solana vault swap test hooks Nov 27, 2024
@kylezs kylezs enabled auto-merge November 27, 2024 14:12
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (f007d1c) to head (0acb8df).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5452    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        494     494            
  Lines      87659   87535   -124     
  Branches   87659   87535   -124     
======================================
- Hits       62670   62492   -178     
- Misses     22379   22432    +53     
- Partials    2610    2611     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs added this pull request to the merge queue Nov 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2024
* chore: initiate_vault_swap_hook_called_n_times

* chore: close_accounts_hook_called_n_times

* chore: get_sol_nonces_hook_called_n_times

* chore: typo
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@albert-llimos albert-llimos added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit d4f68cc Nov 28, 2024
49 checks passed
@albert-llimos albert-llimos deleted the chore/tidy-vault-swap-test-hooks branch November 28, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants