Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom-rpc finalized block subscriptions #5456

Closed

Conversation

nmammeri
Copy link
Contributor

Pull Request

Closes: PRO-1768

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

Non-Breaking changes

If this PR includes non-breaking changes, select the non-breaking label. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.

@nmammeri nmammeri requested a review from dandanlen as a code owner November 28, 2024 11:39
@nmammeri nmammeri changed the title feat: custom_rpc finalized block subscriptions feat: custom-rpc finalized block subscriptions Nov 28, 2024
@nmammeri nmammeri marked this pull request as draft November 28, 2024 11:43
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 100 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (d4f68cc) to head (31564a9).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/lib.rs 0% 97 Missing ⚠️
state-chain/node/src/service.rs 0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5456    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        494     494            
  Lines      87666   87642    -24     
  Branches   87666   87642    -24     
======================================
- Hits       62674   62530   -144     
- Misses     22381   22498   +117     
- Partials    2611    2614     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmammeri nmammeri closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant