Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove op codes from btc vault swap encoding #5465

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

j4m1ef0rd
Copy link
Contributor

Pull Request

Closes: PRO-1845

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Fixed a bug in the auto assigning of affiliate short id's in the broker api.
  • Removed the op codes from the nulldata utxo.
  • Renamed the nulldata_utxo -> nulldata_payload seems it's no longer a complete uxto.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (d12200a) to head (d4af5c8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
api/lib/src/lib.rs 75% 11 Missing ⚠️
state-chain/runtime/src/runtime_apis.rs 0% 3 Missing ⚠️
state-chain/runtime/src/lib.rs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5465    +/-   ##
======================================
  Coverage     72%     72%            
======================================
  Files        494     494            
  Lines      87751   87949   +198     
  Branches   87751   87949   +198     
======================================
+ Hits       62826   63010   +184     
- Misses     22310   22358    +48     
+ Partials    2615    2581    -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/lib/src/lib.rs Outdated Show resolved Hide resolved
bouncer/shared/send_btc.ts Outdated Show resolved Hide resolved
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 077b85b Dec 5, 2024
49 checks passed
@j4m1ef0rd j4m1ef0rd deleted the feat/btc-vault-swap-remove-opcodes branch December 5, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants