Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom rpc finalized block subscriptions #5466

Merged

Conversation

nmammeri
Copy link
Contributor

@nmammeri nmammeri commented Dec 4, 2024

Pull Request

Closes: PRO-1768

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Adds new chain head api inside custom-rpc
  • Changes subscription to use the new chainHead_v1_follow api
  • Adds a new only_finalized parameter specifying whether to subscribe to finalized or best blocks
  • Manual tests were conducted to test functionality

@nmammeri nmammeri requested a review from dandanlen as a code owner December 4, 2024 15:03
@nmammeri nmammeri changed the title Feature/pro 1768/custom rpc finalized block subscriptions feat: custom rpc finalized block subscriptions Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 107 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (c70d72c) to head (54de5e5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/lib.rs 0% 104 Missing ⚠️
state-chain/node/src/service.rs 0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5466    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        494     494            
  Lines      88073   88004    -69     
  Branches   88073   88004    -69     
======================================
- Hits       63191   63011   -180     
- Misses     22305   22413   +108     
- Partials    2577    2580     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmammeri nmammeri force-pushed the feature/pro-1768/custom-rpc-finalized-block-subscriptions branch from 875c2d9 to 008ef92 Compare December 5, 2024 15:34
@dandanlen dandanlen force-pushed the feature/pro-1768/custom-rpc-finalized-block-subscriptions branch from 300a566 to 4c0b271 Compare December 6, 2024 10:52
@dandanlen dandanlen enabled auto-merge December 6, 2024 13:39
@dandanlen dandanlen added this pull request to the merge queue Dec 6, 2024
@dandanlen dandanlen removed this pull request from the merge queue due to a manual request Dec 6, 2024
@dandanlen dandanlen enabled auto-merge December 6, 2024 14:55
@dandanlen dandanlen added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2024
@nmammeri nmammeri force-pushed the feature/pro-1768/custom-rpc-finalized-block-subscriptions branch from b4cfe42 to 7df6227 Compare December 9, 2024 10:29
@dandanlen dandanlen enabled auto-merge December 9, 2024 12:01
@dandanlen dandanlen added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@dandanlen dandanlen added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit e8cbf84 Dec 10, 2024
49 checks passed
@dandanlen dandanlen deleted the feature/pro-1768/custom-rpc-finalized-block-subscriptions branch December 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants