-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: runtime metadata hash verification #5467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a bouncer test that uses the metadata hash - we can add this separately.
Yes, that would be nice. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5467 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 494 495 +1
Lines 87751 88004 +253
Branches 87751 88004 +253
======================================
+ Hits 62826 62971 +145
- Misses 22310 22453 +143
+ Partials 2615 2580 -35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I couldn't resist the urge to sort the dependencies though 🙈
Also, just confirm - right now we never build the runtime with the extension enabled. I expect that we want to add this to the release or production profile at some point. I think we can discuss this later depending on product / testing concerns.
Pull Request
Closes: PRO-1733
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.
Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breaking
label. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.