Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct exit code on engine error #5470

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Dec 5, 2024

Pull Request

Closes: PRO-1887

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Given we never expect the engine to exit, when it does exit it should exit with a "1" exit code, so unix systems can interpret it as an error correctly.

@kylezs kylezs requested review from dandanlen and ahasna December 5, 2024 23:11
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72%. Comparing base (74e50be) to head (22c0cb8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5470    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        494     494            
  Lines      88050   87926   -124     
  Branches   88050   87926   -124     
======================================
- Hits       63159   62981   -178     
- Misses     22312   22365    +53     
- Partials    2579    2580     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Dec 6, 2024
@dandanlen dandanlen added the non-breaking Merging this PR will create a cherry-pick onto release label Dec 6, 2024
Merged via the queue into main with commit 15e1787 Dec 6, 2024
49 checks passed
@dandanlen dandanlen deleted the fix/return-correct-exit-code branch December 6, 2024 09:53
dandanlen pushed a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Merging this PR will create a cherry-pick onto release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants