Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move broker api subscription to custom-rpc #5474

Merged

Conversation

nmammeri
Copy link
Contributor

@nmammeri nmammeri commented Dec 6, 2024

Pull Request

Closes: PRO-1886

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Added cf_subscribe_transaction_screening_events to custom_rpc that uses the new finalized notification behavior
  • Modified broker-api subscribe_transaction_screening_events to use the custom-rpc equivalent function
  • Also, changed the logic slightly so that it returns an empty events vector if there are no events detected, making it consistent with other custom-rpc subscriptions

@nmammeri nmammeri requested a review from dandanlen as a code owner December 6, 2024 16:44
@nmammeri nmammeri requested review from MxmUrw and removed request for dandanlen December 6, 2024 16:44
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (09292c9) to head (a2e4bf6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/lib.rs 0% 10 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5474    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        495     495            
  Lines      88124   88010   -114     
  Branches   88124   88010   -114     
======================================
- Hits       63144   62967   -177     
- Misses     22401   22464    +63     
  Partials    2579    2579            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MxmUrw MxmUrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broker API changes look good, tested with the deposit monitor, works as expected. For custom-rpc stuff maybe someone else should also have a look.

@nmammeri nmammeri force-pushed the feature/pro-1886/move-broker-api-subscription-to-custom-rpc branch from ab6f5c1 to a2e4bf6 Compare December 11, 2024 10:13
@dandanlen dandanlen added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 24cb41c Dec 11, 2024
48 checks passed
@dandanlen dandanlen deleted the feature/pro-1886/move-broker-api-subscription-to-custom-rpc branch December 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants