Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow insecure connections with subxt #5479

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Dec 9, 2024

Included in 1.7.4 release already: #5478

@dandanlen dandanlen requested a review from kylezs as a code owner December 9, 2024 16:24
@dandanlen dandanlen enabled auto-merge December 9, 2024 16:26
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (86c4e99) to head (d10b385).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/dot/rpc.rs 0% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5479    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        494     494            
  Lines      88073   87955   -118     
  Branches   88073   87955   -118     
======================================
- Hits       63189   63011   -178     
- Misses     22304   22363    +59     
- Partials    2580    2581     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 9, 2024
@kylezs kylezs force-pushed the fix/insecure-subxt-is-ok branch from 6dbf316 to d10b385 Compare December 9, 2024 23:00
@kylezs kylezs enabled auto-merge December 9, 2024 23:00
@kylezs kylezs added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 4469f9b Dec 10, 2024
49 checks passed
@kylezs kylezs deleted the fix/insecure-subxt-is-ok branch December 10, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants