Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Solana skip preflight only for CCM #5480

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

albert-llimos
Copy link
Contributor

@albert-llimos albert-llimos commented Dec 9, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Following the approach of EVM, where the transaction specifies some of the broadcasting parameters (gas_limit, max_fee_per_gas ...), I've added the skip_preflight to the Solana transactions.
For CCM transactions can revert so we do want to force broadcast it. For non-CCM transactions we expect them to succeed so we'd rather broadcast them only if they succeed (aka not skip preflight).

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 17.02128% with 39 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (c70d72c) to head (48193e6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rc/migrations/solana_transaction_data_migration.rs 0% 25 Missing ⚠️
engine/src/sol/retry_rpc.rs 8% 12 Missing ⚠️
engine/src/state_chain_observer/sc_observer.rs 0% 1 Missing ⚠️
state-chain/chains/src/sol/benchmarking.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5480    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        494     495     +1     
  Lines      88073   87991    -82     
  Branches   88073   87991    -82     
======================================
- Hits       63191   63017   -174     
- Misses     22305   22395    +90     
- Partials    2577    2579     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albert-llimos albert-llimos marked this pull request as ready for review December 10, 2024 09:34
@albert-llimos albert-llimos changed the title chore: skip preflight only ccm chore: skip Solana preflight only for CCM Dec 10, 2024
@albert-llimos albert-llimos changed the title chore: skip Solana preflight only for CCM chore: Solana skip preflight only for CCM Dec 10, 2024
Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I made a couple of small changes (see commits).

engine/src/sol/retry_rpc.rs Outdated Show resolved Hide resolved
@albert-llimos albert-llimos added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 2232236 Dec 10, 2024
49 checks passed
@albert-llimos albert-llimos deleted the feat/solana-skip-preflight-only-ccm branch December 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants