-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Solana skip preflight only for CCM #5480
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5480 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 494 495 +1
Lines 88073 87991 -82
Branches 88073 87991 -82
======================================
- Hits 63191 63017 -174
- Misses 22305 22395 +90
- Partials 2577 2579 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - I made a couple of small changes (see commits).
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Following the approach of EVM, where the transaction specifies some of the broadcasting parameters (
gas_limit
,max_fee_per_gas
...), I've added theskip_preflight
to the Solana transactions.For CCM transactions can revert so we do want to force broadcast it. For non-CCM transactions we expect them to succeed so we'd rather broadcast them only if they succeed (aka not skip preflight).