feature: Added affiliates to cf_account_info rpc #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5491 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 495 495
Lines 88137 88044 -93
Branches 88137 88044 -93
======================================
- Hits 63152 62973 -179
- Misses 22420 22502 +82
- Partials 2565 2569 +4 ☔ View full report in Codecov by Sentry. |
dandanlen
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Janislav
force-pushed
the
feat/pro-1884/add-affiliates-to-account-info
branch
2 times, most recently
from
47ed548 to
9540f15
Compare
* feature: Added channel address to cf-account-info * refactor: derive address from channel id * refactor: renamed channel_address to deposit_address * chore: renamed deposit_address -> btc_vault_deposit_address * chore: moved btc address derivation to own function * chore: improved comment * chore: refactored cf_broker_info
Janislav
force-pushed
the
feat/pro-1884/add-affiliates-to-account-info
branch
from
9540f15 to
c6c3431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1884
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Adds the associated affiliates of a broker account to the response of the cf_account_info rpc.
Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breakinglabel. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.