-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Network Fee from Boost #5495
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5495 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 495 495
Lines 88124 88254 +130
Branches 88124 88254 +130
======================================
+ Hits 63144 63170 +26
- Misses 22401 22516 +115
+ Partials 2579 2568 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👌 only pretty minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Pull Request
Closes: PRO-1778
Summary
NetworkFeeDeductionFromBoostPercents
representing the % of boost fee to be taken as network fee. Its value is initially 0, and can be updated viaupdate_pallet_config
governance extrinsic.DepositFinalised
(when action isBoostersCredited
) now additionally exposesnetwork_fee_swap_request_id
(of the network fee swap), andnetwork_fee_from_boost
(the amount of input asset to be swapped).network_fee_deduction
tocf_boost_pool_details
rpc.I haven't added network_fee_decution to
DepositBoosted
(there still seems to be an ongoing discussion whether this should be necessary), but it shouldn't be too difficult to add if needed (though maybe with a name indicating that it is not confirmed?).