chore: Removed upgrade condition for pending swaps #5497
Merged
+5
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5497 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 495 495
Lines 88137 88253 +116
Branches 88137 88253 +116
======================================
+ Hits 63152 63172 +20
- Misses 22420 22514 +94
- Partials 2565 2567 +2 ☔ View full report in Codecov by Sentry. |
kylezs
reviewed
Dec 12, 2024
| @@ -730,7 +730,7 @@ impl pallet_cf_governance::Config for Runtime { | |||
| type WeightInfo = pallet_cf_governance::weights::PalletWeight<Runtime>; | |||
| type UpgradeCondition = ( | |||
| pallet_cf_validator::NotDuringRotation<Runtime>, | |||
| (pallet_cf_swapping::NoPendingSwaps<Runtime>, pallet_cf_environment::NoUsedNonce<Runtime>), | |||
There was a problem hiding this comment.
We can delete the NoPendingSwaps struct too
There was a problem hiding this comment.
I think we can remove NoUsedNonce too? @marcellorigotti ?
kylezs
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1680
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Removes the obsolete check for pending swaps during a runtime upgrade.
Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breakinglabel. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.