Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expires_at field to request swap parameter encoding #5506

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nmammeri
Copy link
Contributor

@nmammeri nmammeri commented Dec 16, 2024

Pull Request

Closes: PRO-1851

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Return estimated_expires_at field determining when the payload is considered expired.
  • Only implemented for Bitcoin for now, Solana implementation should be straightforward when Solana vault swapping is in main
  • Updated bouncer btc_vault_swap test to validate the expiry estimated_expires_at

@nmammeri nmammeri requested review from kylezs and removed request for martin-chainflip December 16, 2024 12:23
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (8c4fd61) to head (0143d3c).

Files with missing lines Patch % Lines
state-chain/runtime/src/runtime_apis.rs 0% 11 Missing ⚠️
state-chain/runtime/src/lib.rs 29% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5506    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        495     495            
  Lines      88383   88282   -101     
  Branches   88383   88282   -101     
======================================
- Hits       63348   63174   -174     
- Misses     22467   22530    +63     
- Partials    2568    2578    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs
Copy link
Contributor

kylezs commented Dec 16, 2024

See my comment on the linear issue, I think having an RPC endpoint will be much more robust and less error prone, and probably best not to have integrators depend on something we know will change.

@nmammeri nmammeri marked this pull request as draft December 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants