Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

document azure blob storage setup #149

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

migmartri
Copy link
Member

Signed-off-by: Miguel Martinez Trivino <migmartri@gmail.com>
@migmartri migmartri requested a review from danlishka September 27, 2023 13:53
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -8,27 +8,25 @@ import Tabs from "@theme/Tabs";
import TabItem from "@theme/TabItem";
import CodeBlock from "@theme/CodeBlock";

As part of an attestation process, you might want to collect different pieces of evidence such as Software Bill Of Materials (SBOMs), test results, runner logs, etc and then attach them to the final in-toto attestation.
As part of an attestation process, you might want to collect different pieces of evidence such as Software Bill Of Materials (SBOMs), test results, runner logs, etc and then attach them to the final in-toto attestation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of an attestation process, you should collect different pieces of evidence, such as Software Bill Of Materials (SBOMs), test results, runner logs, etc., and then attach them to the final in-toto attestation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it that you want to achieve with that change? I am asking because it's hard to know what has changed and why without any context.

@migmartri migmartri merged commit b6c2434 into chainloop-dev:main Sep 27, 2023
@migmartri migmartri deleted the add-azure-docs branch September 27, 2023 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants