修改rule id 98的环境变量增加忽略大小写标记、修复拼写错误 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DVKunion
reviewed
Aug 1, 2023
| @@ -23,7 +23,7 @@ func getRegexp(pattern string) (regex *regexp.Regexp, err error) { | |||
| } else { | |||
| // If it does not exist in the cache, | |||
| // it compiles the pattern and creates one. | |||
| regex, err = regexp.Compile(pattern) | |||
| regex, err = regexp.Compile("(?i)" + pattern) | |||
There was a problem hiding this comment.
这个不建议直接在代码层面去做，如果某些规则需要忽略大小写，那么应该在规则本身去修改正则，而不是在代码层将所有的pattern强制加了忽略大小写，可能会导致很多误报（如AK/SK的规则）
testwill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.