Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output failing ch command line in regenByteCode.py #6981

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ppenzin
Copy link
Member

@ppenzin ppenzin commented Apr 18, 2024

Report failing command when regenerating bytecode in addition to the error.

Report failing command when regenerating bytecode in addition to the
error.
@ppenzin ppenzin requested a review from rhuanjl April 18, 2024 09:18
Copy link
Collaborator

@rhuanjl rhuanjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could make this more descriptive still, but I agree this is an improvement - and not sure how to take it much further.

@rhuanjl rhuanjl merged commit 2af598f into chakra-core:master Apr 18, 2024
21 checks passed
@ppenzin ppenzin deleted the regen-ch-cmd branch April 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants