Fix JsDisableRuntimeExecution on AppleSilicon #6995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuanjl
force-pushed
the
fixArm64DisableRuntime
branch
from
cdaec41
to
16bfa71
Compare
|
I need to check my email a bit more often, sorry. It is failing in debug mode on Windows, but Azure already helpfully deleted the build, I am trying to re-run it. |
|
My suspicion is that CI failures are stringize issue returning. I went ahead and merged the relevant PR, this would probably clear after rebase. |
ppenzin
approved these changes
Jul 6, 2024
rhuanjl
force-pushed
the
fixArm64DisableRuntime
branch
from
16bfa71
to
475d3e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsDisableRuntimeExecution currently does not function on AppleSilicon.
This is because of an incorrect ifdef, JsDisableRuntimeExecution works by overriding CC's stack size tracking so that CC mistakenly thinks there is no stack space left and hence stops executing JS; in order to do this
StackLimitForScriptInterruptneeds to be an appropriately large number for the architecture, currently it's being set to the same size on AppleSilicon that was used for x86 which is obviously not high enough, change the ifdef so all 64bit architectures (i.e. x64 and AppleSilicon) get the larger figure.Bug reported by @fatcerberus fix also tested offline by @fatcerberus
Currently most of our native API tests only run on windows hence do not detect this; we should look at enabling them on macOS/Linux as a future todo.