Skip to content

Commit

Permalink
fixed rare dispatch bug
Browse files Browse the repository at this point in the history
  • Loading branch information
chakravala committed Oct 15, 2024
1 parent df57083 commit d152828
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ environment:
- julia_version: 1.8
- julia_version: 1.9
- julia_version: 1.10
- julia_version: 1.11
- julia_version: nightly

platform:
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DirectSum"
uuid = "22fd7b30-a8c0-5bf2-aabe-97783860d07c"
authors = ["Michael Reed"]
version = "0.8.14"
version = "0.8.15"

[deps]
ComputedFieldTypes = "459fdd68-db75-56b8-8c15-d717a790f88e"
Expand Down
2 changes: 1 addition & 1 deletion src/operations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ for side ∈ (:left,:right)
args = field ? (:g,) : ()
@eval begin
@pure function $c(b::Submanifold{V,G,B},$(args...)) where {V,G,B}
$(ch ? nothing : side:right ? :(((!isdiag(V) && !hasconformal(V)) || $field) && (return $s(metric(b,$(args...))))) : :(((!isdiag(V) && !hasconformal(V)) || $field) && (return $(field ? :wedgedot_metric : :*)(reverse(b),V(LinearAlgebra.I)))) )
$(ch ? nothing : side:right ? :(((!isdiag(V) && !hasconformal(V)) || $field) && (return $s(metric(b,$(args...))))) : :(((!isdiag(V) && !hasconformal(V)) || $field) && (return $(field ? :wedgedot_metric : :*)(reverse(b),V(LinearAlgebra.I),$(args...)))) )
d = getbasis(V,complement(mdims(V),B,diffvars(V),$(ch ? 0 : :(hasinf(V)+hasorigin(V)))))
isdyadic(V) && throw(error("Complement for mixed tensors is undefined"))
v = $(ch ? :($pn(V,B,value(d))) : :(value(d)))
Expand Down

2 comments on commit d152828

@chakravala
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/117558

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.15 -m "<description of version>" d152828f2d3023a2d5c327a0a4517839b972217e
git push origin v0.8.15

Please sign in to comment.