Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update turbulent taylor couette time stepping in example #1235

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Aug 8, 2024

Description

The Taylor-Couette example was using constant time-stepping and a BDF3 time-integrator. This is not a good practice for this example. I have updated the parameter file, the prm file and also the .png files of the results. The new results are much better especially for fine meshes.

Code related list:

  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb requested a review from lpsaavedra August 8, 2024 14:52
Copy link
Collaborator

@lpsaavedra lpsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update to the example! I have only a few comments

@blaisb
Copy link
Contributor Author

blaisb commented Aug 8, 2024

I applied all of your comments @lpsaavedra

@blaisb blaisb requested a review from lpsaavedra August 8, 2024 16:04
@blaisb blaisb merged commit e27c86c into master Aug 8, 2024
3 checks passed
@blaisb blaisb deleted the update_turbulent_taylor_couette_time_stepping branch August 8, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants