Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chartmuseum backend auth #34

Closed
wants to merge 2 commits into from
Closed

Chartmuseum backend auth #34

wants to merge 2 commits into from

Conversation

dabde
Copy link

@dabde dabde commented Jan 14, 2020 •
edited
Loading

Add support for chartmuseum with basic auth enabled.

additionally:

  • upgrade alpine image (3.11)
  • fix some css
  • update to go modules
  • removed vendor folder

tests:

  • show charts is working
  • delete, not able to test (not working in UI yet, api call failed with missing post.tpl file)
  • upload, not able to test (not working in UI failed with missing post.tpl file)

@dabde
Copy link
Author

dabde commented Jan 14, 2020

resolve #20 - basic auth for chartmuseum
maybe resolve #31 - https for backend (had no issues against my https CM after changes)

@dabde dabde requested a review from idobry January 21, 2020 13:16
@dabde
Copy link
Author

dabde commented Jun 24, 2021

Will close this MR. No review for 1 1/2 years looks like project is abandoned.

@dabde dabde closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idobry idobry Awaiting requested review from idobry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dabde