Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef main wrapper fetch and persist license #3266

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Chef main wrapper fetch and persist license #3266

merged 4 commits into from
Oct 24, 2024

Conversation

ashiqueps
Copy link
Contributor

Description

Removed the feature flag and implemented the FetchAndPersist of chef-licensing go component

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ashiqueps ashiqueps requested review from a team as code owners August 7, 2024 12:21
@ashiqueps ashiqueps marked this pull request as draft August 7, 2024 12:21
@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

👷 Deploy Preview for chef-workstation processing.

Name Link
🔨 Latest commit 4cc22ab
🔍 Latest deploy log https://app.netlify.com/sites/chef-workstation/deploys/6719f31dd7a8a60008136f9e

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

nikhil2611 and others added 4 commits October 24, 2024 12:28
@nikhil2611 @ashiqueps
removed the feature flag for licensing and called the licensing package
666879b 
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
@ashiqueps
Updated the chef-main-wrapper with the licensing changes
fead342 
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
@ashiqueps
Updated the env lookup scenario
8b1543c 
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
@ashiqueps
exclude shell-init from license enforcement
4cc22ab 
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
@ashiqueps ashiqueps force-pushed the CHEF-3919-chef-bin-license-updates branch from d0800a9 to 4cc22ab Compare October 24, 2024 07:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ashiqueps ashiqueps changed the base branch from main to workstation-LTS October 24, 2024 07:12
@ashiqueps ashiqueps marked this pull request as ready for review October 24, 2024 07:12
@ashiqueps ashiqueps merged commit 9d713ad into workstation-LTS Oct 24, 2024
4 of 7 checks passed
@ashiqueps ashiqueps deleted the CHEF-3919-chef-bin-license-updates branch October 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil2611 nikhil2611 nikhil2611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashiqueps @nikhil2611