cc link puts target_linkflags into rspfile to resolve --whole-archive input exceed maximal length of bash #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UT failed. You can remove the failed tests or try to run tests in the non-rspfile mode. |
noanswer
changed the title
noanswer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on fix: exceed maximal length of bash when linking #927, put the target_linkflags parameters into rspfile
If the target depends on too many proto_library or use too many link_all_symbols on purpose, the --whole-archive may be too long to break the max length of bash single argument.
Ninja will start any command with /bin/sh -c "{command}". The command will act as a single argument in bash.
Query single argument max length:
printf %d $((32 * $(getconf PAGE_SIZE) ))