regex fix (#282)

chillerlan · Oct 16, 2024 · f822e80 · f822e80
1 parent 9964cf8
commit f822e80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Data/AlphaNum.php b/src/Data/AlphaNum.php
@@ -36,7 +36,7 @@ public function getLengthInBits():int{
 	}
 
 	public static function validateString(string $string):bool{
-		return (bool)preg_match('#^['.self::CHAR_MAP.']+$#', $string);
+		return (bool)preg_match('/^[A-Z\d %$*+-.:\/]+$/', $string);
 	}
 
 	public function write(BitBuffer $bitBuffer, int $versionNumber):static{

diff --git a/tests/Data/AlphaNumTest.php b/tests/Data/AlphaNumTest.php
@@ -34,6 +34,15 @@ public static function stringValidateProvider():array{
 		return [
 			['ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890 $%*+-./:', true],
 			['abc', false],
+			['ÄÖÜ', false],
+			[',', true],
+			['-', true],
+			['+', true],
+			['.', true],
+			['*', true],
+			[':', true],
+			['/', true],
+			['\\', false],
 		];
 	}