-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional group API #3541
Add optional group API #3541
Conversation
0fd68cd
to
eff55f5
Compare
eff55f5
to
d70540f
Compare
The documentation will fail until |
Hey Schuyler, thanks for working on this. Do you guys have an idea when this will make it into a Chisel v6 release (v6.0.0-M4 I assume)? |
That's a @jackkoenig question. I think we're probably ready for a true 6.0 release and not a milestone at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, nice work Schuyler! I've included some suggestions, but overall looks really good.
b31aaa5
to
cadb03f
Compare
Add support for optional groups. These are groups of statements with optional functionality. The primary use case is intended for verification code to "extract" such code into bound modules. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
cadb03f
to
6a731fb
Compare
Add optional groups.
Example
Chisel:
Output FIRRTL:
Output Verilog:
Release Notes
Add optional groups. This is a feature that can be used to add optional verification functionality, e.g., asserts or debug code, that does not affect the main design. These groups are lowered to FIRRTL Optional Groups (see: chipsalliance/firrtl-spec#108) with the "bind" convention.