-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] jextract, adopt: 20 -> 21 #3551
Conversation
Last night's CI failed trying to grab jextract 20: https://github.com/chipsalliance/chisel/actions/runs/6311071188/job/17134348465 . Looking at https://jdk.java.net/jextract/ the latest is 21, although there's a special page for 19 that maybe is more likely to stick around (?) ? Didn't look much into why 20 disappeared, especially since these are "early access" builds. |
chisel/.github/workflows/test.yml Line 91 in 2be8bbc
Should be upgraded as well. |
Done! Although unfortunately new error: https://github.com/chipsalliance/chisel/actions/runs/6313202496/job/17140770653?pr=3551
Suggestions welcome, just meant to fix a 404 (which also failed a test, but not sure I understand why) -- I'll take a closer look at some point if no one else does or knows what's going on 👍 . |
Sigh, |
Maybe try this link? |
Great, looks like it was just temporarily down. Closing, thanks all! CI run since then passes: https://github.com/chipsalliance/chisel/actions/runs/6324383804 |
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.5.x
,3.6.x
, or5.x
depending on impact, API modification or big change:6.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.