Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename localPrefixAppliesToSelf to localModulePrefixAppliesToSelf #4528

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jackkoenig
Copy link
Contributor

Labeling No Release Notes because the API this is modifying has not yet been released.

The slightly more concise localPrefixAppliesToSelf does not add value and may imply to users that it modifies more things than just localModulePrefix. So I decided to make it more verbose and clear.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the No Release Notes Exclude from release notes, consider using Internal instead label Nov 26, 2024
@jackkoenig jackkoenig added this to the 7.0 milestone Nov 26, 2024
@jackkoenig jackkoenig requested a review from mwachs5 November 26, 2024 19:14
@jackkoenig jackkoenig merged commit 118502e into main Nov 26, 2024
18 checks passed
@jackkoenig jackkoenig deleted the localModulePrefixAppliesToSelf branch November 26, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants