Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto generated DedupGroups to be sensitive to module prefix #4545

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Also fix logic for naming PseudoModules which should ignore the prefix.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Also fix logic for naming PseudoModules which should ignore the prefix.
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Dec 3, 2024
@jackkoenig jackkoenig added this to the 7.0 milestone Dec 3, 2024
@jackkoenig jackkoenig requested a review from mwachs5 December 3, 2024 00:04
*/
private[chisel3] def _proposedName: String = this match {
// PseudoModules (e.g. Instances) and BlackBoxes have their names set by desiredName.
case _: PseudoModule => desiredName
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The careful reviewer will notice this changed from Module.currentModulePrefix + desiredName. It turns out that for Instances (which have an underlying PseudoModule, the currentModulePrefix is always empty so it's effectively a no-op. For other PseudoModules like ViewParent, there is no reason to have a prefix. I tweaked the code to make it more obvious that the prefix is not actually relevant to PseudoModules.

@jackkoenig jackkoenig enabled auto-merge (squash) December 3, 2024 00:14
@jackkoenig jackkoenig merged commit aebb874 into main Dec 3, 2024
16 checks passed
@jackkoenig jackkoenig deleted the prefix-dedupgroup branch December 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants