Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Convert LayerSpec to use FileCheck, NFC #4547

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

seldridge
Copy link
Member

Convert chiselTests.LayerSpec to use FileCheck. This is much stricter testing as the ordering of matches is now guaranteed.

Convert `chiselTests.LayerSpec` to use FileCheck.  This is much stricter
testing as the ordering of matches is now guaranteed.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@seldridge seldridge added the No Release Notes Exclude from release notes, consider using Internal instead label Dec 4, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider massaging tabbing.

src/test/scala/chiselTests/LayerSpec.scala Outdated Show resolved Hide resolved
@seldridge seldridge enabled auto-merge (squash) December 4, 2024 03:58
@seldridge seldridge disabled auto-merge December 4, 2024 04:01
@seldridge seldridge merged commit 876f5f6 into main Dec 4, 2024
11 checks passed
@seldridge seldridge deleted the dev/seldridge/cleanup-layer-tests branch December 4, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants