Upgrade Scalafmt to 3.8.3

[jackkoenig]

As you can see, there's a bit of a diff. I've done the best I can to minimize it but there's some diff.

It seems to try to keep argument lists on one line, which I like, but it does it even if an early argument list was split between multiple lines which is a bit weird.

It also likes keeping case on the same line as the { which I like, although occasionally that leads to longish lines. Anyway, we can try to massage this further or just go with it. I think it's fine but am curious what others think.

We will need to bump Scalafmt soon in order to support Scala 3.

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

• Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
• Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you do one of the following when ready to merge:
  • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
  • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

[mwachs5]

this is prettier

[mwachs5]

the spot checks of what i saw look nice. The alignment on => is definitely more aggressive, that would be the only thing I'd wonder if you want to turn off but I also like it if we're erring on the side of alignment

[azidar]

I definitely like putting the case on the same line! Overall I think its good.

[azidar]

It's a bit strange to me to align the types, but not the = ? But I suppose that might be a much larger diff, which is fine to avoid.