WIP Support MacOS build and test #1984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgugala
requested changes
Oct 16, 2023
|
|
||
| - name: Install Mac Dependencies | ||
| run: | | ||
| brew install uhdm surelog yosys |
There was a problem hiding this comment.
I suppose we should build everything here (not try to install those packages with brew), so we're sure we test against the exact version of the deps pinned with submodules
There was a problem hiding this comment.
Sure, though of course surelog and uhdm are available via homebrew, and soon synlig will be as well.
so long as the dependencies are pinned to release versions and not random git hashes, it should be easy to distribute via homebrew and other registries.
There was a problem hiding this comment.
Actually I think we should have both tests - one without and one with brew.
|
@timkpaine can you rebase this PR (so we have changes from #2073 included) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1980
Will not work yet until a few other things are finished, so please do not approve/run the CI (I'm testing on my fork)