(#141) Ensure the bootstrap script is written as-is #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set-Content can cause a trailing newline to be added, which will break the signature if the script is signed.
vexx32
force-pushed
the
141-signing
branch
2 times, most recently
from
a811584
to
407ab9e
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Motivation and Context
Ensure we don't append newlines by accident when saving the bootstrapping script.
Testing
Testing this is non-trivial, which is why this PR remains in draft for now; Ansible by default runs everything with an execution policy of Unrestricted, so I'm not sure how to force the check as seen in the linked issue.
Operating Systems Testing
Win10
Change Types Made
Change Checklist
Related Issue
Fixes #141 (hopefully) 😁