Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rtd for docs #167

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Use rtd for docs #167

merged 7 commits into from
Jul 13, 2023

Conversation

mikemhenry
Copy link
Contributor

No description provided.

@mikemhenry mikemhenry added this to the 0.3.1 milestone Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #167 (2d383eb) into master (5619889) will not change coverage.
The diff coverage is n/a.

@yuanqing-wang
Copy link
Member

@kntkb @mikemhenry the build doc is still failing, is it supposed to be fixed in this PR?

@yuanqing-wang
Copy link
Member

@mikemhenry @kntkb oh nvm I see that we just need to disable the previous build docs GA

@ijpulidos
Copy link
Contributor

Yeah, this one should be ready to go https://espaloma--167.org.readthedocs.build/en/167/

Anybody opposing merging this as it is now?

@yuanqing-wang
Copy link
Member

let's merge once we can disable "Build Doc / docs (push)" GA

@mikemhenry
Copy link
Contributor Author

Sorry! I was just about done with this PR and got distracted, I will clean it up now that it is building!

@mikemhenry
Copy link
Contributor Author

Okay auto merge should take care of this, I will keep an eye on it

@ijpulidos ijpulidos self-requested a review July 13, 2023 19:11
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yuanqing-wang yuanqing-wang merged commit 2e92ecb into master Jul 13, 2023
3 checks passed
@yuanqing-wang yuanqing-wang deleted the feat/use_RTD_for_docs branch July 13, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants