using dgl.to_homogeneous instead of the old deprecated name.
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemhenry
approved these changes
Jul 14, 2023
|
@ijpulidos is this one ready to go? Did our unit tests not catch this because of a DGL version pin? |
I think the issue is that we are not really testing this, we should probably write a test that uses it but I honestly don't think I could come up with one before the release (if we want to release today). |
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DGL method is now named
to_homogeneous.This should fix tests breaking on downstream packages, such as in https://github.com/openmm/openmmforcefields/actions/runs/5555278333/jobs/10146203523?pr=289#step:9:1959