Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch to update to new dgl version #179

Merged
merged 19 commits into from
Aug 21, 2023
Merged

Conversation

mikemhenry
Copy link
Contributor

I am still building DGL packages, so right now only testing what I have, which is a python 3.9 build. We have some errors to fix to get it to work with dgl 1.1.0

@mikemhenry mikemhenry added the installation 🛠️ I can't install espaloma label Jul 21, 2023
@mikemhenry
Copy link
Contributor Author

Okay sorry for the noise, the test failures now in CI are from API changes in DGL

@mikemhenry
Copy link
Contributor Author

Sweet, CPU builds work!

@mikemhenry
Copy link
Contributor Author

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@dd8ebb7). Click here to learn what that means.
The diff coverage is n/a.

@mikemhenry mikemhenry mentioned this pull request Aug 17, 2023
5 tasks
@mikemhenry
Copy link
Contributor Author

OSX failures right now are from the osx builds missing from the label I am using, as soon as the ubuntu ones finish I can re-run the failed osx builds and it should be fine, but I don't want to interrupt the current linux builds

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mikemhenry mikemhenry merged commit 6229a3e into main Aug 21, 2023
7 checks passed
@mikemhenry mikemhenry deleted the feat/update_to_dgl_1.1.0 branch August 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation 🛠️ I can't install espaloma
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants