-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlkEthOH interaction-typing task #20
base: main
Are you sure you want to change the base?
Conversation
now being tracked by git-lfs
What's the rationale behind just using the rings? Limiting the number of compounds? |
No rationale, just a starting point -- intention is still to use also the AlkEthOH chains set and other sets listed in #2 (comment) and #2 (comment) . |
Hmm, although the Pytorch views in https://github.com/choderalab/espaloma/blob/973d5e1de00b60390b93a054c4277db632569b04/espaloma/data/alkethoh/pytorch_datasets.py satisfy the pytorch Dataset interface, they don't yet play nice with DataLoader. For example, import torch
dataset = AlkEthOHAtomTypesDataset()
loader = torch.utils.data.DataLoader(dataset, batch_size=10, shuffle=True) runs into this error:
Possible workarounds:
|
per discussion with JDC and YW
* AlkEthOHDataset knows how to load things from disk * AlkEthOHTypesDataset(AlkEthOHDataset) knows how to compute categorical loss * AlkEthOH{Atom|Bond|Angle|Torsion}TypesDataset's index into the appropriate types
Add datasets for tasks of classifying atom/bond/angle/torsion types for molecules in AlkEthOH rings set, and provide simple rule-based baselines for each task.
Done:
AlkEthOH{Atom|Bond|Angle|Torsion}TypesDataset
sTodo:
hfgp
toespaloma
pkg_resources.resource_filename
s)