Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert restraint forces to inherit from CVCustomForce #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrrizzi
Copy link
Contributor

These features were implemented originally in #365 and merged in #363, but we had to move them to a separate PR because we haven't resolved the performance issues that come with the CVCustomForce yet.

If the OpenMM performance does not increase, we may need to expose both versions: CVCustomForce and CustomCentroidBondForce.

@jchodera
Copy link
Member

I think we had decided to expose both CustomCVForce and non-CustomCVForce versions of these. Perhaps it would be simplest to retain the original force objects in openmmtools.forces and instead put the new CustomCVForce forces in openmmtools.cvforces, so we can simply import from one or the other to get the desired functionality?

@andrrizzi
Copy link
Contributor Author

I agree, but I'll keep this PR open until we solve the problem in any case as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants