Improve example/template.py for speed, functionality, and readability #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianjianjiang
force-pushed
the
improve_example_template_py
branch
2 times, most recently
from
15a8384 to
4627dd0
Compare
tianjianjiang
changed the title
- python 2-to-3 compatibility - eliminate redundant function calls - especially regex replace calls - use pool.imap for multi-process - supporting scale-decorated template, e.g. `U:%x[0,0]:-1.5` - applying several linting guidelines
tianjianjiang
force-pushed
the
improve_example_template_py
branch
from
4627dd0 to
8864ac2
Compare
|
I think this patch has good parts and unnecessary parts. Redundant calls, Py3 compatibility and cleaner/idiomatic code is something I think is needed. That said, the parts I don't agree is the performance patches. I strongly believe that example code should have a strong focus on it's pedagogical properties; nothing more, nothing less. Introducing extra complexity for the sake of performance in example code increases the learning curve, and seems like it would bring in more harm than gain. |
|
See also: #109 |
|
@cynthia I don't have strong opinions about this PR. It is indeed nice to keep one and only one strong focus for each example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U:%x[0,0]:-1.5This revision trades memory footprint and multicore for speed.
For example, when processing 50k sentences of some Japanese corpus, if the original version spent 3 minutes and 37 seconds, the revised version only needed 20 seconds with 4 processes.