fixed typos, changed how window-refresh was handled for lang file

README.md

@@ -14,7 +14,7 @@ It's called Utsushi's charm because I thought it would be funny to make a comple
 
 # New Update (Updated June 1st)
 - 1.5.2
-  - Adds updated checking
+  - Adds update checking
     - Allows for independent skills/auto-corrections/localization updates
   - Adds initial support for localization (only through command line flags however (`-a` or `--app-language`))
 - 1.5.1
@@ -92,7 +92,7 @@ It's called Utsushi's charm because I thought it would be funny to make a comple
 ## Supported App Language:
 - English
 
-Looking for people who can submit translations. Use (this file)[data/translations/eng.json] and replace the messages appropriately if you are interested in contributing. Create a pull request to show up as a contributor within Github. I can add you in this readme if you only want to create an issue with the translations.
+Looking for people who can submit translations. Use [this file](data/translations/eng.json) and replace the messages appropriately if you are interested in contributing. Create a pull request to show up as a contributor within Github. I can add you in this readme if you only want to create an issue with the translations.
 
 I am currently working on a translation to French.
 

data/translations/eng.json

@@ -58,8 +58,8 @@
     "charms-to-fix": "Charms to fix:",
     "repair-charms": "Fix Parsing Errors",
     "new-version": "A New Version is Available",
-    "new-app-update": "A new version for Utsushi's Charm is available (You: {} vs New: {}), do you want to download it?",
-    "new-skill-update": "New skills were released in-game (You: {} vs New: {}), do you want to update your skill list?",
-    "new-app-language-update": "An updated language file for Utsushi's Charm is available (You: {} vs New: {}), do you want to download it?",
-    "new-skill-correction-update": "New automatic skill corrections were submitted (You: {} vs New: {}), do you download them?"
+    "new-app-update": "A new version for Utsushi's Charm is available (You: {}, New: {}), do you want to download it?",
+    "new-skill-update": "New skills were released in-game (You: {}, New: {}), do you want to update your skill list?",
+    "new-app-language-update": "An updated language file for Utsushi's Charm is available (You: {}, New: {}), do you want to download it?",
+    "new-skill-correction-update": "New automatic skill corrections were submitted (You: {}, New: {}), do you download them?"
 }

src/__main__.py

@@ -72,16 +72,15 @@ def main(args):
         )
 
         if new_lang_update:
-            main_window, translator = create_main_window(args, main_window)
+            translator = Translator(app_language_code)
+            main_window.refresh(translator)
 
         main_window.mainloop()
 
 
-def create_main_window(args, old_window=None):
+def create_main_window(args):
     app_language_code = get_language_code(args.app_language)
     translator = Translator(app_language_code)
-    if old_window is not None:
-        old_window.destroy()
     new_window = MainWindow(translator, args)
     new_window.report_callback_exception = handle_exception
     sys.stdout = new_window

src/resources.py

@@ -133,7 +133,7 @@ def get_latest_url():
 
 
 def get_language_url(language="eng"):
-    url = f"https://raw.githubusercontent.com/chpoit/utsushis-charm/master/data/translation/{language}.json"
+    url = f"https://raw.githubusercontent.com/chpoit/utsushis-charm/master/data/translations/{language}.json"
     return url
 
 

src/ui/MainWindow.py

@@ -19,6 +19,7 @@ class MainWindow(tk.Tk):
     def __init__(self, _: Translator, args):
         super().__init__()
         self.charms = CharmList()
+        self.args = args
 
         self.title(_("Utsushi's Charm"))
         try:
@@ -44,6 +45,12 @@ def __init__(self, _: Translator, args):
         self._regen_paths()
         self._build_ui()
 
+    def refresh(self, _: Translator = None):
+        if not _:
+            _ = self._
+        self.destroy()
+        self.__init__(_, self.args)
+
     def _build_ui(self, _: Translator = None):
         if not _:
             _ = self._

src/updater/Updater.py

@@ -41,6 +41,8 @@ def update_language(self, lang, new_version: SimpleSemVer):
         except PermissionError as e:
             logger.exception("Could not write language file")
             print(_("lang-permission-denied"))
+        except Exception as e:
+            logger.exception("An error occurred")
 
     def update_skill_corrections(self, lang, new_version: SimpleSemVer):
         _ = self._
@@ -52,12 +54,12 @@ def update_skill_corrections(self, lang, new_version: SimpleSemVer):
             Path(full_name_new).touch()
             request.urlretrieve(url, filename=full_name_new, data=None)
             self.version_checker.update_corrections_version(lang, new_version)
+            self.merge_corrections(full_name, full_name_new)
         except PermissionError as e:
             logger.exception("Could not write corrections file")
             print(_("skill-cor-permission-denied"))
-            return
-
-        self.merge_corrections(full_name, full_name_new)
+        except Exception as e:
+            logger.exception("An error occurred")
 
     def update_all_skills(self, new_version: SimpleSemVer):
         url = get_english_skill_mapping_url()
@@ -70,7 +72,8 @@ def update_all_skills(self, new_version: SimpleSemVer):
         except PermissionError as e:
             logger.exception("Could not write skill file")
             print(_("skill-permission-denied"))
-            return
+        except Exception as e:
+            logger.exception("An error occurred")
 
     def merge_corrections(self, full_name, full_name_new):
         with open(full_name, "r", encoding="utf-8") as old_f: