Skip to content

Commit

Permalink
llvmPackages: unify version for all platforms but Darwin (NixOS#343245)
Browse files Browse the repository at this point in the history
  • Loading branch information
emilazy authored Sep 22, 2024
2 parents 5ff4f7b + bb7c7d6 commit 6177650
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -15431,18 +15431,12 @@ with pkgs;
libllvm = llvmPackages.libllvm;
llvm-manpages = llvmPackages.llvm-manpages;

# Please remove all this logic when bumping to LLVM 19 and make this
# a simple alias.
llvmPackages = let
# This returns the minimum supported version for the platform. The
# assumption is that or any later version is good.
choose = platform:
/**/ if platform.isDarwin then 16
else if platform.isFreeBSD then 18
else if platform.isOpenBSD then 18
else if platform.isAndroid then 12
else if platform.isLinux then 18
else if platform.isWasm then 16
# For unknown systems, assume the latest version is required.
else 18;
choose = platform: if platform.isDarwin then 16 else 18;
# We take the "max of the mins". Why? Since those are lower bounds of the
# supported version set, this is like intersecting those sets and then
# taking the min bound of that.
Expand Down

0 comments on commit 6177650

Please sign in to comment.